productionlist: Put the full production in production.rawsource #6358
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## 2.0 #6358 +/- ##
==========================================
+ Coverage 83.64% 84.21% +0.57%
==========================================
Files 278 276 -2
Lines 40239 39692 -547
Branches 5931 5866 -65
==========================================
- Hits 33657 33427 -230
+ Misses 5250 4950 -300
+ Partials 1332 1315 -17
Continue to review full report at Codecov.
|
tk0miya
requested changes
May 13, 2019
This makes it possible to iterate over the productions and see exactly the text that was entered by the author, which is useful to e.g. extract information from the grammar (like syntax-highlighting patterns).
cpitclaudel
force-pushed
the
production_rawsource
branch
from
c1a66e0
to
44c8a3b
Compare
|
Done! (I think? :) |
tk0miya
approved these changes
May 14, 2019
|
Merged. Thank you for your contribution :-) |
tk0miya
added a commit
that referenced
this pull request
May 14, 2019
tk0miya
reviewed
May 14, 2019
| @@ -12,6 +12,8 @@ Incompatible changes | |||
| * #6230: The anchor of term in glossary directive is changed if it is consisted | |||
| by non-ASCII characters | |||
| * #4550: html: Centering tables by default using CSS | |||
| * The ``rawsource`` property of ``production`` nodes now contains the full | |||
| production rule. | |||
There was a problem hiding this comment.
Note: I moved this entry to features list.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes it possible to iterate over the productions and see exactly the text
that was entered by the author, which is useful to e.g. extract information from
the grammar (like syntax-highlighting patterns).