Add %O% option to make.bat template; update docs #6363
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## 2.0 #6363 +/- ##
=======================================
Coverage 83.64% 83.64%
=======================================
Files 278 278
Lines 40239 40239
Branches 5931 5931
=======================================
Hits 33657 33657
Misses 5250 5250
Partials 1332 1332Continue to review full report at Codecov.
|
tk0miya
requested changes
May 13, 2019
The make.bat_t and make.bat.new_t templates now pass %O% as well as %SPHINXOPTS% to `sphinx-build`, in parity with Makefile.new_t. The sphinx-build documentation page was updated to explicitly note $(O) and %O% as shortcut variables. Closes sphinx-doc#6323, per the comment thread discussion.
bskinn
force-pushed
the
6323_makebat_o_opt
branch
from
6f9404d
to
0dbdae3
Compare
|
@tk0miya Sure! commit is revised. |
tk0miya
approved these changes
May 13, 2019
|
Thank you for quick work. Merged! |
tk0miya
added a commit
that referenced
this pull request
May 13, 2019
|
Absolutely! Thanks for all your efforts contributing to the maintenance & improvement of the project! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Subject
Add
%O%option to make.bat templates.Feature or Bugfix
Detail
The
make.bat_tandmake.bat.new_ttemplates now pass%O%as well as%SPHINXOPTS%tosphinx-build, in parity withMakefile.new_t.The
sphinx-builddocumentation page was updated to explicitly note$(O)and%O%as shortcut variables.Closes #6323, per the comment thread discussion there.
Purpose
sphinx-quickstartRelates