Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use the same DB session for has_node() as for add_node() #20

Merged
merged 2 commits into from
Jan 2, 2019
Merged

Use the same DB session for has_node() as for add_node() #20

merged 2 commits into from
Jan 2, 2019

Conversation

mitya57
Copy link
Contributor

@mitya57 mitya57 commented Jan 1, 2019

This makes the tests pass with Sphinx 1.8.

Fixes #18.

Cc @shimizukawa @tk0miya

@tk0miya tk0miya mentioned this pull request Jan 2, 2019
Closed
tk0miya
tk0miya reviewed Jan 2, 2019
View reviewed changes
Copy link
Member

@tk0miya tk0miya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not good at this module. But it looks good to me :-)

@tk0miya tk0miya merged commit b009184 into sphinx-doc:master Jan 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tk0miya tk0miya tk0miya left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mitya57 @tk0miya