Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Copy resource files to static directory #22

Merged

Conversation

takuan-osho
Copy link
Contributor

@takuan-osho takuan-osho commented Jan 13, 2019

This PR is for #53.

I used https://github.com/shimizukawa/sphinx-websupport-app as a test of this PR.

If this PR is merged, Sphinx core could remove resource files such as comment-bright.png from Sphinx itself.

Copy link
Member

@tk0miya tk0miya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with nits!

sphinxcontrib/websupport/builder.py Show resolved Hide resolved
sphinxcontrib/websupport/builder.py Outdated Show resolved Hide resolved
sphinxcontrib/websupport/builder.py Outdated Show resolved Hide resolved
@takuan-osho takuan-osho force-pushed the copy-image-resources-from-sphinx-core branch from 6f2eb72 to 4a08470 Compare January 13, 2019 07:10
takuan-osho added a commit to takuan-osho/sphinxcontrib-websupport that referenced this pull request Jan 13, 2019
@takuan-osho takuan-osho force-pushed the copy-image-resources-from-sphinx-core branch from 4a08470 to af3e383 Compare January 13, 2019 07:15
takuan-osho added a commit to takuan-osho/sphinxcontrib-websupport that referenced this pull request Jan 13, 2019
@takuan-osho takuan-osho force-pushed the copy-image-resources-from-sphinx-core branch from af3e383 to 998730a Compare January 13, 2019 07:17
Copy link
Member

@tk0miya tk0miya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@tk0miya tk0miya merged commit ef4d390 into sphinx-doc:master Jan 13, 2019
@takuan-osho takuan-osho deleted the copy-image-resources-from-sphinx-core branch January 13, 2019 07:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants