Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Copy resource files to static directory #22

Merged

Conversation

@takuan-osho
Copy link
Contributor

commented Jan 13, 2019

This PR is for sphinx-doc/sphinx#4064.

I used https://github.com/shimizukawa/sphinx-websupport-app as a test of this PR.

If this PR is merged, Sphinx core could remove resource files such as comment-bright.png from Sphinx itself.

@tk0miya
Copy link
Member

left a comment

LGTM with nits!

sphinxcontrib/websupport/builder.py Show resolved Hide resolved
sphinxcontrib/websupport/builder.py Outdated Show resolved Hide resolved
sphinxcontrib/websupport/builder.py Outdated Show resolved Hide resolved

@takuan-osho takuan-osho force-pushed the takuan-osho:copy-image-resources-from-sphinx-core branch from 6f2eb72 to 4a08470 Jan 13, 2019

takuan-osho added a commit to takuan-osho/sphinxcontrib-websupport that referenced this pull request Jan 13, 2019

@takuan-osho takuan-osho force-pushed the takuan-osho:copy-image-resources-from-sphinx-core branch from 4a08470 to af3e383 Jan 13, 2019

takuan-osho added a commit to takuan-osho/sphinxcontrib-websupport that referenced this pull request Jan 13, 2019

@takuan-osho takuan-osho force-pushed the takuan-osho:copy-image-resources-from-sphinx-core branch from af3e383 to 998730a Jan 13, 2019

@tk0miya
Copy link
Member

left a comment

LGTM!

@tk0miya tk0miya merged commit ef4d390 into sphinx-doc:master Jan 13, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@takuan-osho takuan-osho deleted the takuan-osho:copy-image-resources-from-sphinx-core branch Jan 13, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.