-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Copy resource files to static directory #22
Merged
tk0miya
merged 4 commits into
sphinx-doc:master
from
takuan-osho:copy-image-resources-from-sphinx-core
Jan 13, 2019
Merged
Copy resource files to static directory #22
tk0miya
merged 4 commits into
sphinx-doc:master
from
takuan-osho:copy-image-resources-from-sphinx-core
Jan 13, 2019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tk0miya
requested changes
Jan 13, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM with nits!
6f2eb72
to
4a08470
Compare
takuan-osho
added a commit
to takuan-osho/sphinxcontrib-websupport
that referenced
this pull request
Jan 13, 2019
4a08470
to
af3e383
Compare
takuan-osho
added a commit
to takuan-osho/sphinxcontrib-websupport
that referenced
this pull request
Jan 13, 2019
af3e383
to
998730a
Compare
tk0miya
approved these changes
Jan 13, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is for #53.
I used https://github.com/shimizukawa/sphinx-websupport-app as a test of this PR.
If this PR is merged, Sphinx core could remove resource files such as
comment-bright.png
from Sphinx itself.