New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DOC: fix 'Who uses Sphinx-Gallery' list #1015
Conversation
Could you update it in our README.rst too? |
03edfa4
to
c2abd5e
Compare
02a85d0
to
e87d05c
Compare
e87d05c
to
818cf76
Compare
818cf76
to
88ee498
Compare
sorry for the many pushes. build_docs error is unrelated to this PR, see #1017 . It took a while for me to understand the CI now uses sphinx 5.2.0, I used 5.1.1 locally. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you! Just a nit
88ee498
to
34eea67
Compare
hm, the github rst parser seems to not like the |
maybe this is caused by https://github.com/github/markup#github-markup?:
|
@lucyleeow so I guess I'll have to get back to the original version with the included txt file which isn't ideal but works correctly. |
What about just including the whole Thanks again for working on this! |
Up to about 20 mins ago I was convinced that including the complete txt file into README.rst did work correctly but when I now try to reproduce it I can't make it work (see https://github.com/StefRe/sphinx-gallery/tree/fix/test_who-uses-links). It turns out that including files into rst is blocked for security reasons, see github/markup#172 (comment). Including files into markdown doesn't work either (github/markup#346) and there are obviously no plans to pursue any of this. I'll try and think of another solution. |
PyPi packages also don't process sphinx extension:
(the entry for SG uses |
Let's just get rid of Also in some packages for RST that will only be included (not rendered alone) I've seen |
- prevent the project lists in README.rst and projects_list.rst from becoming out of sync (there were already 2 projects more in README.rst than in projects_list.rst) - fix broken and some permanently redirected links reported by linkcheck Github markup doesn't allow including files into README.rst, so we must include from README.rst. Github doesn't process :ref: or :doc: roles (they are shown literally) so we need to handle the Sphinx Gallery link separately. The intersphinx links were replaced by ordinary links as it's very unlikely that these targets would be changed without a redirect in place.
acf0676
to
a704ada
Compare
Thanks @StefRe ! |
the current link in https://sphinx-gallery.github.io/stable/projects_list.html results in 404.
becoming out of sync by putting the projects list in a text file
to include in both rst files (there were already 2 projects more in
README.rst than in projects_list.rst)
Github markup doesn't allow including files into README.rst, so we must
include from README.rst. Github doesn't process :ref: or :doc: roles
(they are shown literally) so we need to handle the Sphinx Gallery link
separately. The intersphinx links were replaced by ordinary links as
it's very unlikely that these targets would be changed without a
redirect in place.