Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set table.dataframe width to auto in CSS file close #1128 #1137

Merged
merged 3 commits into from May 17, 2023

Conversation

photoniker
Copy link
Contributor

@photoniker photoniker commented May 12, 2023

set the table width of dataframe to auto to avoid clipped cell values (e.g. float values). close #1128

@photoniker photoniker changed the title Set table.dataframe width in CSS file close #1128 Set table.dataframe width to auto in CSS file close #1128 May 12, 2023
@larsoner
Copy link
Contributor

This will only fix the bug for sphinx-gallery's own API/ref docs, not for projects that use SG to generate their docs.

I would have expected the fix to land in this file:

https://github.com/sphinx-gallery/sphinx-gallery/blob/122578b15464be4ec756ae4bf0e0a03367df15f4/sphinx_gallery/_static/sg_gallery-dataframe.css#LL2C33-L2C33

And hopefully just be copy-paste-updated from a newer version of their file that we copied originally. Can you look?

@photoniker
Copy link
Contributor Author

This will only fix the bug for sphinx-gallery's own API/ref docs, not for projects that use SG to generate their docs.

I would have expected the fix to land in this file:

https://github.com/sphinx-gallery/sphinx-gallery/blob/122578b15464be4ec756ae4bf0e0a03367df15f4/sphinx_gallery/_static/sg_gallery-dataframe.css#LL2C33-L2C33

And hopefully just be copy-paste-updated from a newer version of their file that we copied originally. Can you look?

Oh you're totally right. Will Change that!

@larsoner larsoner added the bug label May 16, 2023
@larsoner larsoner merged commit 98d1044 into sphinx-gallery:master May 17, 2023
15 checks passed
@larsoner
Copy link
Contributor

Thanks @photoniker !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

large pandas dataframe print
2 participants