Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MAINT: Replace build_sphinx with sphinx-build #1139

Merged
merged 1 commit into from May 15, 2023

Conversation

oscargus
Copy link
Contributor

@oscargus oscargus commented May 13, 2023

In Sphinx 7.0.1 support for build_sphinx was removed. I think this is the way to go.

Also installs imageio as I think that is not an expected failure...

Edit: install absl-py for Sphinx-dev test. Also, sphinx-dev adds ?hash(?) to href-link so removed the closing " from the test.

@oscargus oscargus force-pushed the sphinxbuild branch 4 times, most recently from e6d2049 to 6bb16ea Compare May 13, 2023 11:36
@oscargus oscargus changed the title Replace build_sphinx with sphinx-build MAINT: Replace build_sphinx with sphinx-build May 13, 2023
Copy link
Contributor

@lucyleeow lucyleeow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix, just a few questions

@lucyleeow
Copy link
Contributor

In Sphinx 7.0.1 support for build_sphinx was removed. I think this is the way to go.

For posterity: sphinx-doc/sphinx#9595

@larsoner larsoner merged commit 830b57f into sphinx-gallery:master May 15, 2023
15 checks passed
@larsoner
Copy link
Contributor

Thanks @oscargus , and @lucyleeow ignore my ping from the other PR, sorry I wasn't following properly! 🤦

@oscargus oscargus deleted the sphinxbuild branch May 15, 2023 19:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants