Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MAINT Add to test_identify_names so class property tested #1180

Merged
merged 1 commit into from Aug 18, 2023

Conversation

lucyleeow
Copy link
Contributor

@lucyleeow lucyleeow commented Aug 18, 2023

Ensure we get to the else in visit_Attribute:

else:
# need to get a in a().b
self.visit(node)

This is probably tested in test_full.py but nice to have in a more 'unit' test.

@larsoner larsoner merged commit 96b08a0 into sphinx-gallery:master Aug 18, 2023
16 checks passed
@larsoner
Copy link
Contributor

Thanks @lucyleeow !

@lucyleeow lucyleeow deleted the tst_idnames branch August 18, 2023 11:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants