Support headings in RST to MD #723
Conversation
This enables support for converting headings from RST into Markdown text for Jupyter Notebooks, with heading levels maintained for entire notebook.
Codecov Report
@@ Coverage Diff @@
## master #723 +/- ##
==========================================
+ Coverage 97.47% 97.49% +0.01%
==========================================
Files 32 32
Lines 3560 3587 +27
==========================================
+ Hits 3470 3497 +27
Misses 90 90
Continue to review full report at Codecov.
|
sphinx_gallery/notebook.py
Outdated
| r'(?P<pre>\A|^[ \t]*\n)' # Start of string or blank line above | ||
| r'(?:(?P<over>[{0}])(?P=over)*\n[ \t]*)?' # Over, with heading space | ||
| r'(?P<heading>\S[^\n]*)\n' # Heading itself | ||
| r'(?P<under>(?(over)(?P=over)|[{0}]))(?P=under)*$' # if over make same |
There was a problem hiding this comment.
'if over matched, make same' ?
There was a problem hiding this comment.
I was battling with flake8 here a bit. Maybe I should interweave comments, or add flake8 ignore?
There was a problem hiding this comment.
Good point, adding # noqa E501 to the end of the line (after the comment) fixes it. It looks messy but I think its okay (unless @larsoner objects)
There was a problem hiding this comment.
I decided to interweave the comments with the regular expression, as I thought it worked out better and allowed more verbose comments.
There was a problem hiding this comment.
Thanks that's clearer. Will help when we look back at this regex!
[ci skip] Co-authored-by: Lucy Liu <jliu176@gmail.com>
[ci skip] Co-authored-by: Lucy Liu <jliu176@gmail.com>
|
Thanks @sdhiscocks |
This enables support for converting headings from RST into Markdown text for Jupyter Notebooks, with heading levels maintained for entire notebook.