Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revamp entire website #19

Merged
merged 84 commits into from
Aug 25, 2020
Merged

Revamp entire website #19

merged 84 commits into from
Aug 25, 2020

Conversation

pradyunsg
Copy link
Collaborator

@pradyunsg pradyunsg commented Jul 29, 2020 •
edited
Loading

Closes #17

This brings in the changes from https://github.com/pradyunsg/sphinx-themes/ into this project, replacing the entire existing project tree with that repository. Notable changes to that repository since last discussion:

  • Significantly cleaned up generation + CI pipelines
  • A completely rewritten README + CONTRIBUTING guide
    • I spent wayy too much time on this, but this covers basically everything so that's good. :)
  • conf.py files are included and linked-to from the gallery
  • CI builds now include the "generated-site" as an artifact that can be downloaded
  • Relicensed to BSD-2-Clause (like the current repository)

Post-merge tasks for maintainers/admins:

  • Change "branch for GitHub Pages", from "master" to "gh-pages".

Notably, this PR technically has fewer themes than master, but I say we add them in a follow up because... well, I'd like to do the "add-the-themes" task later and leave a bit of space for others to pick up some of the themes as well. :)

pradyunsg added 30 commits July 29, 2020 11:12
@pradyunsg
Clean slate
ce61ef8
@pradyunsg
Basic Skeleton
55f3408
@pradyunsg
Checkin initial version
a922978
@pradyunsg
Better names might help?
1503d7d
@pradyunsg
Add a basic JSON sorting utility
bbd46d6
@pradyunsg
Add a bazillion themes from sphinx-themes.org
2c21e57
@pradyunsg
Rename tools/{generate -> render}-index.py
7d718b3 
More consistent with noxfile.py
@pradyunsg
Render each theme in a separate virtualenv
006f9dd 
Also, call out to a script to do this task, to keep noxfile from getting
too complicated.
@pradyunsg
sort: Allow "pypi" to be null
c892118 
This is to accomodate for "default" themes
@pradyunsg
Cleanup themes list
a937998 
We'll add them manually one-by-one since sphinx-themes seems really bad.
@pradyunsg
Allow theme.pypi to be None
6289bc5
@pradyunsg
Refactor render_themes
3ba595e 
- Breakup _build_theme and inline calls into  render_themes
- Allow for better error handling
- Blacken code
@pradyunsg
🎨
0cba6a1
@pradyunsg
Don't clear the virtualenv
79eba73
@pradyunsg
Allow for a 2x screen when screenshotting
28971ce
@pradyunsg
Yes, I know I'm dumb.
2639d07
@pradyunsg
Show Alabaster first, and other builtin themes last
3e3f01d
@pradyunsg
Remove background gradient from template
beadc5d
@pradyunsg
Two column minimal layout
029abc5
@pradyunsg
Everybody knows, relax.
7107484
@pradyunsg
Add a subtle vertical border
5f54ccc
@pradyunsg
Allow for more powerful configuration setting
01e6d9e 
Also lets me get rid of that annoying options key that wasn't being used.
@pradyunsg
Resort the JSON
8b5c49c
@pradyunsg
Don't use special null/None for theme.pypi
52b5131
@pradyunsg
Be nicer when a theme image is missing
a75d073 
This shouldn't happen online, but is for development
@pradyunsg
Oops
f21b7f6
@pradyunsg
Make debugging a bit easier
bd978e7
@pradyunsg
No need to be noisy in CI
c283a3f
@pradyunsg
The new normal
235fc4a
@pradyunsg
Space things out a bit
242f2c8
pradyunsg added 14 commits July 29, 2020 14:52
@pradyunsg pradyunsg force-pushed the revamp-entire-website branch from 7d439a2 to 6e35df3 Compare July 29, 2020 09:22
@pradyunsg pradyunsg mentioned this pull request Jul 29, 2020
Closed
@schettino72
Copy link

👍 IMHO A single-column layout (for large screens) would work better.

@pradyunsg
Copy link
Collaborator Author

pradyunsg commented Jul 29, 2020 •
edited
Loading

I tried that locally yesterday, but it didn't look right to me on a 15" laptop screen or on my 34" monitor.

Having a single column means that all the width goes towards to making the images bigger, something that I didn't feel was worthwhile given that it's possible to get a good idea for how a theme looks even at half width and if you really need a closer look, there's a preview link available. :)

@schettino72
Copy link

Well, dont need to use 100% of the screen width.
i.e. It is just easier to compare the look on mobile when all images are aligned vertically.

Anyway, just my 2 cents. Thanks for great work.

@pradyunsg pradyunsg mentioned this pull request Jul 30, 2020
Closed
@pradyunsg
Copy link
Collaborator Author

@shirou Nudge.

@shirou
Copy link
Contributor

shirou commented Aug 25, 2020

ah, sorry for late response. OK. let's merge this. but I want to replace the current website after adding themes as much as possible.

Thank you for your great contribution!!

@shirou shirou merged commit 5b992d2 into sphinx-themes:master Aug 25, 2020
@shirou shirou mentioned this pull request Aug 25, 2020
Closed
@pradyunsg pradyunsg deleted the revamp-entire-website branch August 25, 2020 11:15
@pradyunsg
Copy link
Collaborator Author

Whee! Thanks @shirou! ^>^

I'll add the additional sites in a few follow up PRs! Thanks for the push access here. :)

This was referenced Aug 25, 2020
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Thoughts on a revamp?
4 participants
@pradyunsg @schettino72 @shirou @webknjaz