Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Redesign the site, again #73

Merged
merged 5 commits into from
Apr 28, 2021
Merged

Redesign the site, again #73

merged 5 commits into from
Apr 28, 2021

Conversation

pradyunsg
Copy link
Collaborator

@pradyunsg pradyunsg commented Apr 27, 2021 •
edited
Loading

So... I finally finished the rewrite of this site that I nerd-sniped myself into; after seeing https://sphinxthemes.com/. 😅

We now have a pretty favicon! This is what the tab looks like now:

Screenshot 2021-04-27 at 8 17 15 PM

And... it looks much nicer too! (every time you see the cursor pause for a sec, I've clicked)

sphinx-themes.org.April.2021.demo.mp4

@pradyunsg
Audit and clean up themes.json
1b264e3 
- Remove themes that were organisation-specific, project-specific or
  person-specific.
- Remove "sphinx" and "theme" from the display names, since that is
  implied by being on a site called "sphinx-themes.org". :)
- Remove themes that were minor modifications on sphinx-rtd-theme,
  and hadn't been updated in 6+ months.
- Add more themes to the "featured" list, with the intention of
  showcasing the best-looking themes there. The order is arbitrary,
  based on what looked nice to me.
@pradyunsg
Redesign the site, again
8dc0252 
- Offload theme-specific details to the generated documentation.
- Add a favicon, and a good looking illustration.
- Simplify the index page design, with a subtle animation on hover.
- Rewrite the site generation pipeline, to use asyncio.
- Improve the generated sample documentation, fixing broken links and
  removing duplicated images.
- Add guidelines on which themes are included
@pradyunsg
Remove the stray filter by that sneaked in
fca7cdf 
This is something that I'll be adding in a follow up PR.
@pradyunsg
Pacify linters
9d58849
@pradyunsg
Update CI pipeline, to run nox -s publish
e845b34
@pradyunsg
Copy link
Collaborator Author

pradyunsg commented Apr 27, 2021 •
edited
Loading

Here's the 113 MB archive, containing the entire site, as generated by the automation: https://github.com/sphinx-themes/sphinx-themes.org/suites/2597138269/artifacts/56765896

@pradyunsg
Copy link
Collaborator Author

Merging since I think this is a huge improvement over status quo. Lemme know if anyone has any concerns!

@pradyunsg pradyunsg merged commit 32c230b into sphinx-themes:master Apr 28, 2021
@pradyunsg pradyunsg deleted the rewrite-april-2021 branch April 28, 2021 06:06
This was referenced Apr 28, 2021
Closed
Open
Closed
@shirou
Copy link
Contributor

shirou commented May 11, 2021

Thank you for your continuous contribution. And sorry for late response.

The first motivation of sphinx-themes.org is to publish as many themes as possible. Otherwise, I wouldn't have had to do such a large amount of work. My idea is that even if the theme is old or not maintained, I want to publish it as it is because someone might be inspired by it. I also want to show that there are so many themes in Sphinx, even if they are mixture of good and bad.

Also, I do not have a solid axis of what is a good theme and what is a bad. That's why I don't want to "curate".

@pradyunsg pradyunsg mentioned this pull request May 11, 2021
Closed
@pradyunsg
Copy link
Collaborator Author

@shirou 👋🏽

I've opened #80 for discussing your concerns, and I'll respond there later (I'm at $DAY-JOB right now). :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@pradyunsg @shirou