Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Parse issue titles with code #92

Merged
merged 7 commits into from
Apr 20, 2022
Merged

Parse issue titles with code #92

merged 7 commits into from
Apr 20, 2022

Conversation

arisp99
Copy link
Contributor

@arisp99 arisp99 commented Mar 21, 2022

This quick fix should allow sphinx toolbox to parse issue titles with code in them. Tests were run successfully; however, I do not know how to add new tests.

Closes #91.

@auto-assign auto-assign bot requested a review from domdfcoding March 21, 2022 20:09
@domdfcoding
Copy link
Member

Thanks for your contribution. I've changed the implementation slightly to handle quote characters and I've added some tests too.

Let me know if this still works OK for you.

@coveralls
Copy link

coveralls commented Apr 18, 2022 •
edited

Pull Request Test Coverage Report for Build 2196642528

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 4 of 4 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.006%) to 90.999%
Totals Coverage Status
Change from base Build 2195318234: 0.006%
Covered Lines: 3852
Relevant Lines: 4233
💛 - Coveralls

@arisp99
Copy link
Contributor Author

arisp99 commented Apr 19, 2022

Thanks for the edits @domdfcoding! Works and looks good to me!

@domdfcoding domdfcoding enabled auto-merge (squash) April 19, 2022 18:32
@repo-helper repo-helper bot added 🤖 automerge Auto merge is enabled for this pull request. failure: docs The docs check is failing. failure: Linux The Linux tests are failing. failure: Windows The Windows tests are failing. labels Apr 19, 2022
@repo-helper repo-helper bot removed failure: Linux The Linux tests are failing. failure: docs The docs check is failing. failure: Windows The Windows tests are failing. labels Apr 20, 2022
@domdfcoding domdfcoding merged commit 7b5fcf6 into sphinx-toolbox:master Apr 20, 2022
@domdfcoding
Copy link
Member

Hooray, the tests pass!

I will backport this to v2.18.x, as the master branch is geared up for v3 which isn't ready yet.

@arisp99 arisp99 deleted the parse-issue-title-with-code branch April 20, 2022 16:30
domdfcoding added a commit that referenced this pull request Apr 20, 2022
@arisp99 @domdfcoding
Parse issue titles with code (#92)
b13352a 
* Parse issue titles with code

* Format code

* Handle issue titles with quotes and add tests.

* Strip whitespace from issue title.

* Add changelog entry.

Co-authored-by: Dominic Davis-Foster <dominic@davis-foster.co.uk>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@domdfcoding domdfcoding domdfcoding approved these changes

Assignees

@domdfcoding domdfcoding

Labels
🤖 automerge Auto merge is enabled for this pull request.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Sphinx toolbox unable to parse issue titles with code
3 participants
@arisp99 @domdfcoding @coveralls