GraphQL Data Connector docs #267
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
gloomweaver
commented
May 31, 2024
•
gloomweaver
commented
|
@gloomweaver is attempting to deploy a commit to the Spice AI Team on Vercel. A member of the Team first needs to authorize it. |
gloomweaver
force-pushed
the
kkhramkov/graphql-connector-docs
branch
from
8e5109e
to
03e3354
Compare
digadeesh
reviewed
May 31, 2024
There was a problem hiding this comment.
I think we need to add some more details -
- Examples using the different auth types would be good. Since you list the different params and say one is an alternative to the other, its good to provide the examples to make it clear.
- Needs a limitations section. There are limitations because we are doing inference on the json. Let's list them.
Co-authored-by: Aurash Behbahani <aurashb@gmail.com>
Co-authored-by: Aurash Behbahani <aurashb@gmail.com>
Co-authored-by: Aurash Behbahani <aurashb@gmail.com>
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
digadeesh
previously approved these changes
May 31, 2024
Co-authored-by: Aurash Behbahani <aurashb@gmail.com>
Co-authored-by: Aurash Behbahani <aurashb@gmail.com>
Co-authored-by: Aurash Behbahani <aurashb@gmail.com>
Co-authored-by: Aurash Behbahani <aurashb@gmail.com>
Co-authored-by: Aurash Behbahani <aurashb@gmail.com>
Co-authored-by: Aurash Behbahani <aurashb@gmail.com>
Co-authored-by: Aurash Behbahani <aurashb@gmail.com>
ewgenius
reviewed
Jun 3, 2024
gloomweaver
force-pushed
the
kkhramkov/graphql-connector-docs
branch
from
7add9a7
to
95385c8
Compare
digadeesh
previously approved these changes
Jun 3, 2024
digadeesh
approved these changes
Jun 3, 2024
digadeesh
pushed a commit
that referenced
this pull request
Jun 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.