Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support custom SSL certificates for postgres data connector #1081

Merged
merged 9 commits into from Apr 12, 2024
Merged

Support custom SSL certificates for postgres data connector #1081

merged 9 commits into from Apr 12, 2024

Conversation

ewgenius
Copy link
Contributor

@ewgenius ewgenius commented Apr 11, 2024 •
edited

  • set postgresql ssl mode to "require" by default, add validation
  • Update e2e postgres test
  • added pg_sslrootcert parameter to allow setting custom root cert for postgres connector
  • removed redundant pg_insecure parameter, supporting verify-ca and verify-full ssl mode options

@ewgenius ewgenius self-assigned this Apr 11, 2024
digadeesh
digadeesh previously approved these changes Apr 11, 2024
View reviewed changes
@ewgenius ewgenius changed the title evgenii/postgres ssl root cert Support custom SSL certificates for postgres data connector Apr 12, 2024
@ewgenius ewgenius force-pushed the evgenii/postgres-ssl-root-cert branch 2 times, most recently from f1fd2da to 5de5812 Compare April 12, 2024 04:24
@ewgenius ewgenius marked this pull request as ready for review April 12, 2024 04:24
@ewgenius ewgenius requested a review from a team as a code owner April 12, 2024 04:24
@ewgenius ewgenius requested a review from digadeesh April 12, 2024 04:24
@ewgenius ewgenius force-pushed the evgenii/postgres-ssl-root-cert branch from b3f6c3c to 6f9f7c6 Compare April 12, 2024 07:05
@ewgenius ewgenius force-pushed the evgenii/postgres-ssl-root-cert branch from 6f9f7c6 to 74b20f0 Compare April 12, 2024 07:07
@phillipleblanc phillipleblanc merged commit d2cc740 into trunk Apr 12, 2024
16 checks passed
@phillipleblanc phillipleblanc deleted the evgenii/postgres-ssl-root-cert branch April 12, 2024 07:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@phillipleblanc phillipleblanc phillipleblanc approved these changes

@digadeesh digadeesh Awaiting requested review from digadeesh

Assignees

@ewgenius ewgenius

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ewgenius @phillipleblanc @digadeesh