Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow SELECT count(*) for Sqlite Data Accelerator #1166

Merged
merged 3 commits into from
Apr 23, 2024
Merged

Allow SELECT count(*) for Sqlite Data Accelerator #1166

merged 3 commits into from
Apr 23, 2024

Conversation

sgrebnov
Copy link
Contributor

Fixes #1082

For aggregation queries projection param is empty vector. Don't apply projection to schema if it is empty.

sql> select count(*) from taxi_trips
+----------+
| COUNT(*) |
+----------+
| 500      |
+----------+

@sgrebnov sgrebnov requested a review from a team as a code owner April 22, 2024 22:17
@sgrebnov sgrebnov self-assigned this Apr 22, 2024
Jeadie
Jeadie previously approved these changes Apr 22, 2024
View reviewed changes
@sgrebnov sgrebnov enabled auto-merge (squash) April 23, 2024 02:28
@sgrebnov sgrebnov merged commit ca4f081 into trunk Apr 23, 2024
17 checks passed
@sgrebnov sgrebnov deleted the sgrebnov/allow-count branch April 23, 2024 02:34
@sgrebnov sgrebnov mentioned this pull request Apr 23, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ewgenius ewgenius ewgenius approved these changes

@Jeadie Jeadie Jeadie left review comments

Assignees

@sgrebnov sgrebnov

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

SELECT count(*) FROM {table_name} doesn't work with the Sqlite Data Accelerator
3 participants
@sgrebnov @ewgenius @Jeadie