Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow Spice CLI to control runtime installation on Windows #1173

Merged
merged 2 commits into from
Apr 23, 2024
Merged

Allow Spice CLI to control runtime installation on Windows #1173

merged 2 commits into from
Apr 23, 2024

Conversation

sgrebnov
Copy link
Contributor

Spice 0.11.1-alpha release contains necessary improvements for Windows so we don't need the following logic anymore.

  1. Adding empty spiced placeholder file so that Spice CLI can detect Spice runtime
  2. Pre-installing Spice runtime as CLI can now download the latest runtime version automatically (similar to other platforms)

@sgrebnov sgrebnov requested a review from a team as a code owner April 23, 2024 01:40
@sgrebnov sgrebnov self-assigned this Apr 23, 2024
@sgrebnov sgrebnov enabled auto-merge (squash) April 23, 2024 01:49
@sgrebnov sgrebnov merged commit 7995691 into trunk Apr 23, 2024
16 checks passed
@sgrebnov sgrebnov deleted the sgrebnov/impove-win-install branch April 23, 2024 01:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@phillipleblanc phillipleblanc phillipleblanc approved these changes

Assignees

@sgrebnov sgrebnov

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@sgrebnov @phillipleblanc