Properly support Spark Connect filter pushdown #1186
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I've confirmed that is fixes the issue I've seen. Thanks for the quick fix! |
digadeesh
approved these changes
Apr 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a bug in the Databricks Data Connector where filters were not being properly pushed down, resulting in the equivalent of a
SELECT * FROM big_tableand then trying to filter in-memory, which was causing some timeouts and inefficient queries.I attempted to use the in-built DataFusion unparser, but ran into an issue with column quoting and I raised a PR to fix it upstream: apache/datafusion#10198
Once that PR lands and a new version is released, we can start removing our own
expr::to_sqlmethod.