Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rename refresh_interval to refresh_check_interval #1190

Merged
merged 3 commits into from
Apr 24, 2024
Merged

rename refresh_interval to refresh_check_interval #1190

merged 3 commits into from
Apr 24, 2024

Conversation

y-f-u
Copy link
Contributor

@y-f-u y-f-u commented Apr 24, 2024 •
edited

Rename refresh_interval to refresh_check_interval, avoids the confusion with refresh_period

part of #1179

@y-f-u y-f-u requested a review from a team as a code owner April 24, 2024 01:11
@y-f-u y-f-u self-assigned this Apr 24, 2024
phillipleblanc
phillipleblanc previously approved these changes Apr 24, 2024
View reviewed changes
bin/spice/pkg/spec/dataset.go Outdated Show resolved Hide resolved
@y-f-u y-f-u merged commit b0f014d into trunk Apr 24, 2024
17 checks passed
@y-f-u y-f-u deleted the rename-refresh-interval branch April 24, 2024 05:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@phillipleblanc phillipleblanc phillipleblanc approved these changes

Assignees

@y-f-u y-f-u

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@y-f-u @phillipleblanc