Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support Date32 & Date64 in arrow_sql_gen #1217

Merged
merged 11 commits into from
Apr 29, 2024
Merged

Support Date32 & Date64 in arrow_sql_gen #1217

merged 11 commits into from
Apr 29, 2024

Conversation

Jeadie
Copy link
Contributor

@Jeadie Jeadie commented Apr 29, 2024

Changes

  • Support Date32 & Date64 in arrow_sql_gen crate.
  • This allows support for these types to postgres, mysql, sqlite etc (assuming the underlying data backend can support it).

@Jeadie Jeadie requested a review from a team as a code owner April 29, 2024 02:31
@Jeadie Jeadie self-assigned this Apr 29, 2024
phillipleblanc
phillipleblanc reviewed Apr 29, 2024
View reviewed changes
crates/arrow_sql_gen/src/statement.rs Outdated Show resolved Hide resolved
crates/arrow_sql_gen/src/statement.rs Outdated Show resolved Hide resolved
crates/arrow_sql_gen/src/statement.rs Outdated Show resolved Hide resolved
phillipleblanc
phillipleblanc reviewed Apr 29, 2024
View reviewed changes
crates/arrow_sql_gen/src/statement.rs Outdated Show resolved Hide resolved
crates/arrow_sql_gen/src/statement.rs Outdated Show resolved Hide resolved
crates/arrow_sql_gen/src/statement.rs Show resolved Hide resolved
@Jeadie Jeadie mentioned this pull request Apr 29, 2024
Closed
phillipleblanc
phillipleblanc previously approved these changes Apr 29, 2024
View reviewed changes
@Jeadie Jeadie merged commit bba219f into trunk Apr 29, 2024
17 checks passed
@Jeadie Jeadie deleted the jack/date32 branch April 29, 2024 22:35
@Jeadie Jeadie mentioned this pull request Apr 30, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@phillipleblanc phillipleblanc phillipleblanc approved these changes

Assignees

@Jeadie Jeadie

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Jeadie @phillipleblanc