Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add E2E tests for acceleration engines types support #1218

Merged
merged 12 commits into from
Apr 30, 2024

Conversation

sgrebnov
Copy link
Contributor

@sgrebnov sgrebnov commented Apr 29, 2024

Motivation/Why?

  • We have a record of issues related to acceleration backends when specific data type can't be saved locally (runtime panic/error) or query failure.
  • This PR attempts to test all possible types support by acceleration backends by creating local DuckDB instance as a data source containing different types (DuckDB was selected as the one easy to setup locally; if we like this approach we can switch to remote s3/parquet file), enable supported accelerations and compare query results (query source DuckDB) vs accelerated backend (DuckDB, Arrow, sqlite, postgreSQL(not currently covered))

Implements Github workflow to test that acceleration backend correctly support common types.

  1. Creates test duckdb database and populates it with main Arrow types (isolated table per type as some types cause Spice runtime to crash so all types are isolated in own table)
  2. For each type creates spicepod and runs query twice
  • without acceleration
  • with local acceleration
  1. Compares results and creates summary table

Example test run (scroll page down to find summary): https://github.com/spiceai/spiceai/actions/runs/8872467039

Sample report for boolean
image
image
image

@sgrebnov sgrebnov requested a review from a team as a code owner April 29, 2024 02:36
@sgrebnov sgrebnov force-pushed the sgrebnov/acceleration-types-test branch from 4f311e2 to ab0d6e1 Compare April 29, 2024 02:47
@sgrebnov sgrebnov self-assigned this Apr 29, 2024
@sgrebnov sgrebnov force-pushed the sgrebnov/acceleration-types-test branch 2 times, most recently from b0761cd to 11736e4 Compare April 30, 2024 16:34
@sgrebnov sgrebnov force-pushed the sgrebnov/acceleration-types-test branch from 11736e4 to 4a7a51e Compare April 30, 2024 16:43
@sgrebnov sgrebnov force-pushed the sgrebnov/acceleration-types-test branch from a4f8674 to afdcfb6 Compare April 30, 2024 19:06
@sgrebnov sgrebnov merged commit dbc15b7 into trunk Apr 30, 2024
15 checks passed
@sgrebnov sgrebnov deleted the sgrebnov/acceleration-types-test branch April 30, 2024 20:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants