-
Notifications
You must be signed in to change notification settings - Fork 64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add E2E tests for acceleration engines types support #1218
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sgrebnov
force-pushed
the
sgrebnov/acceleration-types-test
branch
from
April 29, 2024 02:47
4f311e2
to
ab0d6e1
Compare
lukekim
reviewed
Apr 29, 2024
13 tasks
sgrebnov
force-pushed
the
sgrebnov/acceleration-types-test
branch
2 times, most recently
from
April 30, 2024 16:34
b0761cd
to
11736e4
Compare
sgrebnov
force-pushed
the
sgrebnov/acceleration-types-test
branch
from
April 30, 2024 16:43
11736e4
to
4a7a51e
Compare
digadeesh
reviewed
Apr 30, 2024
sgrebnov
force-pushed
the
sgrebnov/acceleration-types-test
branch
from
April 30, 2024 19:06
a4f8674
to
afdcfb6
Compare
digadeesh
approved these changes
Apr 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation/Why?
Implements Github workflow to test that acceleration backend correctly support common types.
Example test run (scroll page down to find summary): https://github.com/spiceai/spiceai/actions/runs/8872467039
Sample report for boolean