Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Snowflake login support (username and password) #1272

Merged
merged 3 commits into from
May 3, 2024

Conversation

sgrebnov
Copy link
Contributor

@sgrebnov sgrebnov commented May 1, 2024

Implements #1273: login support for default Snowflake auth option: username and password

Note: Snowflake account parameter is planned to be part of dataset definition.

@sgrebnov sgrebnov requested a review from a team as a code owner May 1, 2024 18:25
@sgrebnov sgrebnov self-assigned this May 1, 2024
Copy link
Contributor

@digadeesh digadeesh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM but please don't submit until you have a data connector to go with it.

@sgrebnov sgrebnov enabled auto-merge (squash) May 3, 2024 00:45
@sgrebnov sgrebnov merged commit 22acd1b into trunk May 3, 2024
8 checks passed
@sgrebnov sgrebnov deleted the sgrebnov/snowflake-login branch May 3, 2024 00:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants