Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor duckdb to properly set access_mode for connection #1285

Merged
merged 10 commits into from
May 5, 2024
Merged

Refactor duckdb to properly set access_mode for connection #1285

merged 10 commits into from
May 5, 2024

Conversation

ewgenius
Copy link
Contributor

@ewgenius ewgenius commented May 2, 2024 •
edited

closes #1264

Refactored DuckDB connection factory to utilize access_mode:

Note about concurrency - https://duckdb.org/docs/connect/concurrency

One process can both read and write to the database.
Multiple processes can read from the database, but no processes can write (access_mode = 'READ_ONLY').

  • connector uses read_only connection
  • accelerator uses read_write connection

@ewgenius ewgenius requested a review from a team as a code owner May 2, 2024 14:19
@ewgenius ewgenius self-assigned this May 2, 2024
@ewgenius ewgenius changed the title Refactor duckdb use consistent "open" param for connector/accelerator and properly use access_mode Refactor duckdb to use consistent "open" param for connector/accelerator and add access_mode param May 2, 2024
digadeesh
digadeesh previously approved these changes May 2, 2024
View reviewed changes
@ewgenius ewgenius changed the title Refactor duckdb to use consistent "open" param for connector/accelerator and add access_mode param Refactor duckdb to use consistent "open" param for connector/accelerator properly set access_mode May 3, 2024
@ewgenius ewgenius requested a review from digadeesh May 3, 2024 00:15
@ewgenius ewgenius changed the title Refactor duckdb to use consistent "open" param for connector/accelerator properly set access_mode Refactor duckdb to properly set access_mode for connection May 3, 2024
@ewgenius ewgenius requested a review from Sevenannn May 3, 2024 13:20
@ewgenius ewgenius merged commit 2ae4799 into trunk May 5, 2024
15 checks passed
@ewgenius ewgenius deleted the evgeini/refactor-duckdb-connector branch May 5, 2024 02:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@digadeesh digadeesh digadeesh approved these changes

@phillipleblanc phillipleblanc Awaiting requested review from phillipleblanc

@Sevenannn Sevenannn Awaiting requested review from Sevenannn

Assignees

@ewgenius ewgenius

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

The DuckDb file connection failed to establish due to an existing open write connection
3 participants
@ewgenius @digadeesh @Sevenannn