Add if not exists clause to create statement on when creating a table using duckdb acceleration. #1290
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…are using file based duckdb
|
Fixes: #1263 |
digadeesh
changed the title
phillipleblanc
approved these changes
May 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the case that we're using file based duckdb acceleration, we get an error if we start spice, stop it, and restart, because the table already exists.
For other persistent stores, postgres and sqlite, we check for existence. If there is a change in schema in the data connector, it'll still error out. But thats OK since a schema change would probably be a situation where you'd want the user to think and take action before erasing existing data.