Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Postgres data connector - handle invalid host/port and username/password errors #1292

Merged
merged 13 commits into from
May 6, 2024

Conversation

ewgenius
Copy link
Contributor

@ewgenius ewgenius commented May 3, 2024

Part of #1270

  • Misconfigured host or port name
    CleanShot 2024-05-06 at 12 45 27@2x

  • Misconfigured username/password
    CleanShot 2024-05-06 at 12 47 34@2x

crates/runtime/src/dataconnector.rs Outdated Show resolved Hide resolved
crates/runtime/src/dataconnector.rs Outdated Show resolved Hide resolved
phillipleblanc
phillipleblanc previously approved these changes May 3, 2024
phillipleblanc
phillipleblanc previously approved these changes May 3, 2024
crates/db_connection_pool/src/postgrespool.rs Outdated Show resolved Hide resolved
crates/runtime/src/dataconnector.rs Outdated Show resolved Hide resolved
@ewgenius ewgenius force-pushed the evgenii/postgres-friendly-errors/host-and-port branch from 0cdd932 to eea1aab Compare May 6, 2024 03:25
@ewgenius ewgenius changed the title Postgres data connector - handle invalid host/port error Postgres data connector - handle invalid host/port and username/password errors May 6, 2024
@ewgenius ewgenius requested a review from y-f-u May 6, 2024 03:50
@ewgenius ewgenius merged commit e52f1af into trunk May 6, 2024
15 checks passed
@ewgenius ewgenius deleted the evgenii/postgres-friendly-errors/host-and-port branch May 6, 2024 03:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants