Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Snowflake: better error messages, support for role and long queries #1296

Merged
merged 11 commits into from
May 6, 2024

Conversation

sgrebnov
Copy link
Contributor

@sgrebnov sgrebnov commented May 3, 2024

  1. Move account identifier from dataset definition to secrets as it is user account specific.
  2. Support for account identifier with '<orgname.account_name>' format. Default when your copy account identifier from Snowflake account info UI
  3. Make warehouse parameter optional (Snowflake supports defining default Warehouse, for example for user or role) and make naming consistent with other data connectors: snowflake_warehouse
  4. Add snowflake_role parameter to define target role to use
  5. Better error messages and support for longer Snowflake queries by switching to custom swnoflake-api branch (0.8.0-async-exec). Corresponding PRs:

@sgrebnov sgrebnov requested a review from a team as a code owner May 3, 2024 20:38
@sgrebnov sgrebnov self-assigned this May 3, 2024
@sgrebnov sgrebnov changed the title Improve Snowflake Data Connector support Improve Snowflake Data Connector May 3, 2024
phillipleblanc
phillipleblanc previously approved these changes May 6, 2024
Cargo.toml Outdated Show resolved Hide resolved
phillipleblanc
phillipleblanc previously approved these changes May 6, 2024
@sgrebnov sgrebnov changed the title Improve Snowflake Data Connector Snowflake connector: better error messages, support for role and long queries May 6, 2024
@sgrebnov sgrebnov merged commit d27a206 into trunk May 6, 2024
16 of 17 checks passed
@sgrebnov sgrebnov deleted the sgrebnov/sf-move-account branch May 6, 2024 15:39
@sgrebnov sgrebnov changed the title Snowflake connector: better error messages, support for role and long queries Snowflake: better error messages, support for role and long queries May 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants