Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Read sqlite_file param and use it as path #1309

Merged
merged 3 commits into from
May 7, 2024
Merged

Read sqlite_file param and use it as path #1309

merged 3 commits into from
May 7, 2024

Conversation

Sevenannn
Copy link
Contributor

@Sevenannn Sevenannn commented May 6, 2024 •
edited

@Sevenannn Sevenannn marked this pull request as ready for review May 6, 2024 18:49
@Sevenannn Sevenannn requested a review from a team as a code owner May 6, 2024 18:49
@Sevenannn Sevenannn marked this pull request as draft May 6, 2024 18:52
digadeesh
digadeesh previously approved these changes May 6, 2024
View reviewed changes
@Sevenannn Sevenannn marked this pull request as ready for review May 6, 2024 19:26
@Sevenannn Sevenannn requested review from digadeesh and a team May 6, 2024 19:26
@Sevenannn Sevenannn merged commit 6981ed1 into trunk May 7, 2024
16 checks passed
@Sevenannn Sevenannn deleted the qianqian/sqlite-fix branch May 7, 2024 05:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@phillipleblanc phillipleblanc phillipleblanc approved these changes

@digadeesh digadeesh digadeesh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

SQLite accelerator doesn't use the filename specified in params. Instead creates its own file
3 participants
@Sevenannn @phillipleblanc @digadeesh