Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Snowflake key-pair authentication #1314

Merged
merged 8 commits into from
May 7, 2024

Conversation

sgrebnov
Copy link
Contributor

@sgrebnov sgrebnov commented May 6, 2024

Part of #1305

PR adds support for Snowflake key-pair auth via snowflake_auth_type: keypairand snowflake_private_key_path: <path> params. Both unencrypted and encrypted (via passphrase) keys are supported.

version: v1beta1
kind: Spicepod
name: test
datasets:
- from: snowflake:snowflake_sample_data.tpch_sf1.lineitem
  name: lineitem
  params:
    snowflake_auth_type: keypair
    snowflake_private_key_path: /Users/name/rsa_key.p8
    snowflake_private_key_passphrase: 12345

Remaining steps for full key-pair authentication support:

  1. Done Add support for encrypted private keys (passphrase/password parameter and logic to decrypt the key)
  2. Add key-pair support to Spice CLI (key-pair login for Snowflake)

@sgrebnov sgrebnov requested a review from a team as a code owner May 6, 2024 22:22
@sgrebnov sgrebnov self-assigned this May 7, 2024
@sgrebnov sgrebnov changed the title Add support for Snowflake key-pair authentication (v1 - unencrypted keys) Add support for Snowflake key-pair authentication May 7, 2024
@sgrebnov sgrebnov enabled auto-merge (squash) May 7, 2024 03:57
phillipleblanc
phillipleblanc previously approved these changes May 7, 2024
crates/db_connection_pool/src/snowflakepool.rs Outdated Show resolved Hide resolved
@sgrebnov sgrebnov disabled auto-merge May 7, 2024 05:29
@sgrebnov sgrebnov merged commit 7e31137 into trunk May 7, 2024
16 checks passed
@sgrebnov sgrebnov deleted the sgrebnov/sf-key-pair-support branch May 7, 2024 06:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants