Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add TLS support in Postgres connector #970

Merged
merged 16 commits into from Mar 28, 2024
Merged

Add TLS support in Postgres connector #970

merged 16 commits into from Mar 28, 2024

Conversation

ewgenius
Copy link
Contributor

@ewgenius ewgenius commented Mar 27, 2024 •
edited

closes #868

Added TLS support for PostgreSQL connector.
Added two optional params:

  • --pg_pg_sslmode
  • --pg_insecure - Allows TLS connectivity to servers with invalid/expired certificates
  - from: postgres:my_table
    name: my_table
    description: neon db with TLS enabled
    acceleration:
      enabled: true
      refresh_interval: 10s
      refresh_mode: full
    params:
      pg_host: ep-little-surf-320325.us-west-2.aws.neon.tech
      pg_port: '5432'
      pg_db: main
      pg_user: ewgenius
      pg_pass_key: pgpass 
      pg_sslmode: require
      pg_insecure: true

@ewgenius ewgenius requested a review from a team as a code owner March 27, 2024 11:58
@ewgenius ewgenius self-assigned this Mar 27, 2024
phillipleblanc
phillipleblanc previously approved these changes Mar 27, 2024
View reviewed changes
Jeadie
Jeadie previously approved these changes Mar 27, 2024
View reviewed changes
mitchdevenport
mitchdevenport previously approved these changes Mar 27, 2024
View reviewed changes
@ewgenius ewgenius dismissed stale reviews from mitchdevenport and Jeadie via 1fc53bb March 27, 2024 23:18
@phillipleblanc phillipleblanc marked this pull request as draft March 27, 2024 23:38
@ewgenius ewgenius marked this pull request as ready for review March 28, 2024 06:58
@phillipleblanc phillipleblanc merged commit 99db91a into trunk Mar 28, 2024
15 checks passed
@phillipleblanc phillipleblanc deleted the evgenii/postgres-tls branch March 28, 2024 09:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@phillipleblanc phillipleblanc phillipleblanc approved these changes

@Jeadie Jeadie Jeadie left review comments

@mitchdevenport mitchdevenport mitchdevenport left review comments

@y-f-u y-f-u Awaiting requested review from y-f-u

Assignees

@ewgenius ewgenius

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bug: PostgreSQL DataConnector should support connecting to servers with TLS configured
4 participants
@ewgenius @phillipleblanc @Jeadie @mitchdevenport