Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve circular import error message #450

Merged
merged 1 commit into from Feb 4, 2024

Conversation

marcauberer
Copy link
Member

Improve circular import error message
Those error messages look like this:

[Error|Semantic] ../source2.spice:1:1:
Circular import detected: Circular import detected while importing 'source.spice':

*-----*
|     |
|  source2.spice
|     |
|  source1.spice
|     |
|  source.spice
|     |
*-----*

1  import "source" as s;
   ^^^^^^^^^^^^^^^^^^^^^

@marcauberer marcauberer added the improvement Improvement of an existing feature label Feb 4, 2024
@marcauberer marcauberer added this to the 0.20.0 milestone Feb 4, 2024
@marcauberer marcauberer self-assigned this Feb 4, 2024
@marcauberer marcauberer requested a review from a team as a code owner February 4, 2024 17:43
@marcauberer marcauberer enabled auto-merge (squash) February 4, 2024 17:44
@marcauberer marcauberer merged commit 46fdc70 into main Feb 4, 2024
3 checks passed
@marcauberer marcauberer deleted the feature/improve-circular-import-error-message branch February 4, 2024 17:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement Improvement of an existing feature size/M
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant