Feature request - Disable ContextMenu Item

[elijaholmos]

As a developer, I would like the ability to toggle the enabled/disabled status of a custom ContextMenu Item. For example, the "Report" item in the below screenshot is disabled because it is grayed out and unable to be clicked.

[khanhas]

shouldAdd function parameter is already for returning the condition whether API should append your context menu item in the list. Is there any other use case that disabled status would be useful for?

[elijaholmos]

I know it's a little niche, but the specific situation I wanted it for was an extension that fetched the user's entire library upon initialization and cannot function properly until that is complete. I've already incorporated this into the shouldAdd method so that the button will not appear until the entire user library has been fetched- I was just thinking it would be better on the user-side if they saw the button grayed out rather than completely absent, so that they know the extension is there, just not available to use yet.

[elijaholmos]

I'm not sure how much work it would be to add the ability to toggle button enabled/disabled status from the code... if it's not something you think can be done easily, don't worry about it.

[khanhas]

Nah I think it's reasonable enough. I will add it in next version.

[elijaholmos]

Ok sweet! Thanks for chatting with me.

[khanhas]

I made the change but I won't draft a new spicetify version any time soon. So if you want to try it out, just download this file and replace with the original one in <spicetify directory>/jsHelper/:
https://raw.githubusercontent.com/khanhas/spicetify-cli/master/jsHelper/spicetifyWrapper.js
"disabled" prop should be the last parameter of Item or SubMenu constructor:

const test = new Spicetify.ContextMenu.Item("Test", () => {}, () => true, "album", true);
test.register();

You can set "disabled" prop explicitly and it will be updated visually immediately:

test.disabled = false;

[elijaholmos]

Awesome! I will test this out later today when I get home from work

[elijaholmos]

I replaced my previous spicetifyWrapper.js file with the one you linked, but when I run spicetify apply it is loading in the source code from the old file. Is the old javascript being cached, or could there be something else that I didn't do right?

[khanhas]

Ah no, spicetifyWrapper.js is copied in preprocess, you gotta run spicetify restore backup apply.

[elijaholmos]

That worked perfectly, thanks for the help. The new feature functioned as intended and I encountered zero problems. Thank you!