fix: clear path if invalid AppX path is used #1960
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rxri
requested changes
Sep 28, 2022
rxri
approved these changes
Sep 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reset path if
prefs_pathis of AppX and invalid (which is the majority case ifprefs_pathissue on Windows), hopefully this solves a handful of issues like this (if not all). This should also ease up the switching process from AppX to normal version after the user reads the message mentioned below:Also found out that the AppX
spotify_pathmay still exist after an uninstallation, so added an extra check to be sure.Shows MS Store version warn message on backup along with the
Spicetify not apply on restartsolution and forces the user to respond (and hopefully read) before continuing: