Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs(devtools): add macOS instructions #2086

Merged
merged 2 commits into from
Jan 9, 2023
Merged

docs(devtools): add macOS instructions #2086

merged 2 commits into from
Jan 9, 2023

Conversation

vegerot
Copy link
Contributor

@vegerot vegerot commented Jan 6, 2023 •
edited by rxri
Loading

(docs) Add macOS instructions for enable-devtools

@vegerot vegerot requested a review from a team as a code owner January 6, 2023 00:40
@vegerot vegerot changed the title placeholder for pull request (docs) Add macOS instructions for enable-devtools Jan 6, 2023
CharlieS1103
CharlieS1103 approved these changes Jan 6, 2023
View reviewed changes
Copy link
Member

@CharlieS1103 CharlieS1103 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems good to me, maybe change hit to press though, but that's picky and not really related to the pr

@rxri rxri changed the title (docs) Add macOS instructions for enable-devtools docs(devtools): add macOS instructions Jan 6, 2023
theRealPadster
theRealPadster requested changes Jan 6, 2023
View reviewed changes
Copy link
Member

@theRealPadster theRealPadster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you're specifying each OS, then you need to mention Linux as well. I'd recommend just saying "ctrl/cmd + shift + I"

@vegerot
Copy link
Contributor Author

vegerot commented Jan 6, 2023

If you're specifying each OS, then you need to mention Linux as well. I'd recommend just saying "ctrl/cmd + shift + I"

but it's not shift, it's option (alt)

ctrl/cmd + shift/option + I sounds weird xD

@theRealPadster
Copy link
Member

but it's not shift, it's option (alt)

ctrl/cmd + shift/option + I sounds weird xD

Ahh that's why I could never get the shortcut to work on macos 😂 then I'd just add a "/Linux" to your "(Windows)"

theRealPadster
theRealPadster requested changes Jan 9, 2023
View reviewed changes
Copy link
Member

@theRealPadster theRealPadster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this addresses all the feedback.

spicetify.go Outdated Show resolved Hide resolved
@vegerot @theRealPadster
Update spicetify.go
1b3ad0b 
Co-authored-by: Isaac <padspambox@gmail.com>
@vegerot
Copy link
Contributor Author

vegerot commented Jan 9, 2023

@theRealPadster I don't have permission to merge this PR

@rxri rxri merged commit 50d95d9 into spicetify:master Jan 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@theRealPadster theRealPadster theRealPadster approved these changes

@CharlieS1103 CharlieS1103 CharlieS1103 approved these changes

@rxri rxri Awaiting requested review from rxri rxri was automatically assigned from spicetify/cli

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@vegerot @theRealPadster @CharlieS1103 @rxri