Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(sidebarConfig): resize after closing sidebar config #2118

Merged
merged 5 commits into from
Jan 23, 2023
Merged

fix(sidebarConfig): resize after closing sidebar config #2118

merged 5 commits into from
Jan 23, 2023

Conversation

Tetrax-10
Copy link
Contributor

Resize after closing sidebar config to its user specified size

Before:

before.mp4

After:

after.mp4

resize after closing sidebar config to its user specified size
@Tetrax-10 Tetrax-10 requested a review from a team as a code owner January 23, 2023 08:58
@Tetrax-10
Copy link
Contributor Author

Sry for that formatting 😔 mb.
this is the correct formatting (use tabs). should i edit it?

document.documentElement.style.setProperty(
    "--nav-bar-width",
    localStorage.getItem(`${(await Spicetify.CosmosAsync.get("sp://desktop/v1/session")).username}:nav-bar-width`) + "px"
);

Copy link
Member

@kyrie25 kyrie25 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just need to refactor some stuff.

jsHelper/sidebarConfig.js Outdated Show resolved Hide resolved
jsHelper/sidebarConfig.js Outdated Show resolved Hide resolved
@Tetrax-10
Copy link
Contributor Author

Looks good

jsHelper/sidebarConfig.js Outdated Show resolved Hide resolved
Copy link
Member

@kyrie25 kyrie25 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rxri rxri merged commit 995acb0 into spicetify:master Jan 23, 2023
@Tetrax-10 Tetrax-10 deleted the patch-1 branch January 24, 2023 05:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants