Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(snippets): add 3 element hiding snippets #531

Merged
merged 7 commits into from
Jul 9, 2023
Merged

feat(snippets): add 3 element hiding snippets #531

merged 7 commits into from
Jul 9, 2023

Conversation

Resxt
Copy link
Contributor

@Resxt Resxt commented Jun 29, 2023

No description provided.

@Resxt Resxt requested a review from a team as a code owner June 29, 2023 12:05
@Resxt Resxt requested review from CharlieS1103 and removed request for a team June 29, 2023 12:05
@rxri rxri changed the title feat(snippets): add 3 element hidding snippets feat(snippets): add 3 element hiding snippets Jul 7, 2023
Resxt added 3 commits July 9, 2023 13:22
This solution might not be ideal because it's not hiding the button until you do something, even clicking anywhere, for some reason + using the has pseudo class is expensive from what I've read but this is the only reliable way to do it that I found.

Other ways wouldn't work if you had more buttons in the playbar (like the volume profiles extension adding some volume buttons)
@Resxt Resxt requested a review from kyrie25 July 9, 2023 11:41
@kyrie25 kyrie25 merged commit 31e3643 into spicetify:main Jul 9, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants