Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(package.json): add packageManager #638

Merged
merged 7 commits into from
Nov 4, 2023
Merged

chore(package.json): add packageManager #638

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
f8130d4
chore(package.json): add `packageManager` && make scripts pm-independent
SunsetTechuila Nov 3, 2023
2db2fc6
Merge branch 'main' into pnpm
SunsetTechuila Nov 3, 2023
39ae674
Merge branch 'main' into pnpm
theRealPadster Nov 4, 2023
c7704b3
feat: add pnpm to strict engines
rxri Nov 4, 2023
a5ed56b
Merge branch 'main' into pnpm
SunsetTechuila Nov 4, 2023
8a9b799
style(npmrc): add newline
rxri Nov 4, 2023
2d934c2
Merge branch 'main' into pnpm
theRealPadster Nov 4, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion .github/workflows/build.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,6 @@ jobs:
- name: Install pnpm
uses: pnpm/action-setup@v2
with:
version: latest
run_install: false

- name: Install Node.js (v20)
Expand Down
1 change: 0 additions & 1 deletion .github/workflows/lint.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,6 @@ jobs:
- name: Install pnpm
uses: pnpm/action-setup@v2
with:
version: latest
run_install: false

- name: Install Node.js
Expand Down
1 change: 0 additions & 1 deletion .github/workflows/push.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,6 @@ jobs:
- name: Install pnpm
uses: pnpm/action-setup@v2
with:
version: latest
run_install: false

- name: Install Node.js
Expand Down
1 change: 1 addition & 0 deletions .npmrc
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
engine-strict=true
6 changes: 5 additions & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,10 +9,11 @@
"bugs": {
"url": "https://github.com/spicetify/spicetify-marketplace/issues"
},
"packageManager": "pnpm@8.10.2",
"scripts": {
"build": "spicetify-creator",
"build:local": "spicetify-creator --out=dist --minify",
"build:prod": "pnpm build:local && pnpm copy:docs",
"build:prod": "pnpm run build:local && pnpm run copy:docs",
"copy:docs": "copyfiles README.md dist/",
"lint": "eslint --fix src",
"lint:ci": "eslint src",
Expand All @@ -21,6 +22,9 @@
"prepare": "husky install"
},
"engines": {
"yarn": "please-use-pnpm",
"npm": "please-use-pnpm",
theRealPadster marked this conversation as resolved.
Show resolved Hide resolved
"pnpm": ">=8",
"node": ">=20"
},
"devDependencies": {
Expand Down