Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(fad): lyrics plus positioning #2417

Merged
merged 2 commits into from
Jun 20, 2023
Merged

fix(fad): lyrics plus positioning #2417

merged 2 commits into from
Jun 20, 2023

Conversation

kyrie25
Copy link
Member

@kyrie25 kyrie25 commented Jun 18, 2023

Resolves #2416
image
image

@kyrie25 kyrie25 requested a review from a team as a code owner June 18, 2023 05:05
@Phinsin666

This comment was marked as spam.

@giodaboy

This comment was marked as spam.

@rxri rxri merged commit 53b7f1f into master Jun 20, 2023
@rxri rxri deleted the fix/fad-lp-position branch June 20, 2023 18:08
@Phinsin666

This comment was marked as spam.

@bachig26
Copy link

@kyrie25 @rxri @Lseoksee this issue hasn't been solved. I've tried completely removing the spicetify and reinstalled but still this issue exist.

@kyrie25
Copy link
Member Author

kyrie25 commented Jun 27, 2023

@kyrie25 @rxri @Lseoksee this issue hasn't been solved. I've tried completely removing the spicetify and reinstalled but still this issue exist.

The issue is only fixed in Spicetify’s Full App Display on version 2.20.2.

Any other instance of FAD used via Marketplace or other than built-in Full App Display is not our concern.

@kyrie25
Copy link
Member Author

kyrie25 commented Jun 27, 2023

Please don’t mention maintainers or other people participating because of an issue on your end.

@bachig26
Copy link

Any other instance of FAD used via Marketplace or other than built-in Full App Display is not our concern.

I've used the built-in official spicetify FAD and also removed them when it doesn't work, then furthermore installed by manually downlading the FAD js file to the Entension folder and installed using the cli command. still not working.

@kyrie25
Copy link
Member Author

kyrie25 commented Jun 27, 2023

Attach a screenshot of your config-xpui, the issue, and the About Spotify modal with the Spicetify list expanded.

@kron0800
Copy link

I have the same issue aswell, that is lyrics are half visible in the FAD.

config-xpui:
image

issue itself:
image

about spotify
image

@rxri
Copy link
Member

rxri commented Jun 27, 2023

FAD from marketplace needs to be fixed separately. Like kyrie said:

Any other instance of FAD used via Marketplace or other than built-in Full App Display is not our concern.

@kron0800
Copy link

my bad! i thought it was the oficcial one. where can i find the original extension? or is it the full screen button on the bottom left corner? (if that's the case, how do i enable lyrics)

@kron0800
Copy link

nvm i got it working with spicetify config extensions fullAppDisplay.js

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[fullAppDisplay] The lyrics plus lyrics display is weird
7 participants