Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Potential performance issue: plotting slow in matplotlib == 3.3.0 #85

Closed
HarryCollins2 opened this issue Mar 8, 2024 · 1 comment
Closed
Labels
discussion Discussion on DocEE and SentEE

Comments

@HarryCollins2
Copy link

Description

Hello.
I have discovered a performance degradation in the plot function of matplotlib version 3.3.0. And I notice the repo depends on pandas 3.3.0 in requirements.txt. I am not sure whether this performance problem in matplotlib will affect this repository. I found some discussions on matplotlib GitHub related to this issue, including matplotlib/matplotlib#18743.

Suggestion

I would recommend considering an version change to matplotlib >= 3.3.3 or <3.3.0(e.g. 3.2.2) or exploring other solutions to optimize the performance of plotting.

@HarryCollins2 HarryCollins2 added the discussion Discussion on DocEE and SentEE label Mar 8, 2024
@Spico197
Copy link
Owner

Spico197 commented Mar 8, 2024

Thanks for the information~ Since the fig plotting function is called on offline mode, it does not affect the training and inference speed or performance here. Feel free to upgrade matplotlib to the latest version~

@Spico197 Spico197 closed this as completed Mar 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
discussion Discussion on DocEE and SentEE
Projects
None yet
Development

No branches or pull requests

2 participants