dra: auto convert resourceclaim to multus annotions #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cyclinder
force-pushed
the
dra/annotations2
branch
4 times, most recently
from
009c60c
to
bc3b947
Compare
weizhoublue
reviewed
Jun 6, 2024
hack/build-go.sh
Outdated
| @@ -19,7 +19,7 @@ if [ -z "$VERSION" ]; then | |||
| fi | |||
| set -e | |||
| fi | |||
| DATE=$(date -u -d "@${SOURCE_DATE_EPOCH:-$(date +%s)}" --iso-8601=seconds) | |||
| DATE="1234" | |||
There was a problem hiding this comment.
just for local testing on mac
weizhoublue
reviewed
Jun 6, 2024
| @@ -24,7 +24,9 @@ import ( | |||
| "strings" | |||
There was a problem hiding this comment.
it possibly need some declaration for changing the original code, owing to license issue
or else, it could add a new file for the new code in the module with entirely new license claim
weizhoublue
reviewed
Jun 6, 2024
| @@ -75,7 +77,7 @@ func saveScratchNetConf(containerID, dataDir string, netconf []byte) error { | |||
|
|
|||
| path := filepath.Join(dataDir, containerID) | |||
|
|
|||
| err := ioutil.WriteFile(path, netconf, 0600) | |||
| err := os.WriteFile(path, netconf, 0600) | |||
There was a problem hiding this comment.
I have bump Golang version to 1.22, and the ioutil package has been marked deprecated state,
weizhoublue
reviewed
Jun 6, 2024
weizhoublue
reviewed
Jun 6, 2024
|
add unite test |
cyclinder
force-pushed
the
dra/annotations2
branch
14 times, most recently
from
32d2e2e
to
2270302
Compare
cyclinder
force-pushed
the
dra/annotations2
branch
2 times, most recently
from
4daddff
to
e906f34
Compare
weizhoublue
reviewed
Jun 21, 2024
| @@ -0,0 +1,59 @@ | |||
| package spiderpool | |||
cyclinder
force-pushed
the
dra/annotations2
branch
from
e906f34
to
74e46a7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
dra: auto convert resourceclaim to multus annotions