-
Notifications
You must be signed in to change notification settings - Fork 73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
change the label of auto-created ippool for GC needs #1162
Conversation
50b8b7a
to
6c708c2
Compare
Codecov Report
@@ Coverage Diff @@
## main #1162 +/- ##
=======================================
Coverage 78.85% 78.85%
=======================================
Files 19 19
Lines 1296 1296
=======================================
Hits 1022 1022
Misses 250 250
Partials 24 24
Flags with carried forward coverage won't be shown. Click here to find out more. |
现在版本 不能 狂奔了,应该要正规起来 第一,如果是bug fix,没有 pick 到 release 0.3, 但 release 0.3 是 不兼容的, release 0.3 怎么办? 第二,为什么 label 打的是 “none-required” ,非常 随意 ,release note怎么管理 第三,描述 没说清 "-" 为什么会引起bug 。并且 title 和 描述 只顾 说 代码 做了什么变动,elease note 中,参考者 更多是想看到 什么问题症状,解决了什么问题,才能知道这个版本 修复了它的困境 。 |
(1)已经 发出去的 版本,已经 创建的 ippool 没有这种label,升级后是否存 识别 问题,例如 IP 分配 失败。怎么进行 升级兼容 ?或者说 没法升级 兼容 。 (2)fix application label tracing and do refactor for spider subnet feature label |
6c708c2
to
b1d76a5
Compare
b1d76a5
to
28c0a85
Compare
28c0a85
to
bdb52d5
Compare
ff38467
to
b73c976
Compare
docs/develop/upgrade.md
Outdated
@@ -0,0 +1,27 @@ | |||
# Spiderpool upgrade | |||
|
|||
## Notice |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
这个不能这么写,
如果是所有升级注意 后续 都在 一个文件里,2级别标题 最好是 “低于 v0.3.x 升级到 高于 xx 版本 之类” 的 分类标题,
或者 按照 版本 来规划文件名。
|
||
## Description | ||
|
||
There's a design flaw for SpiderSubnet feature in auto-created IPPool label. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
附上 链上 pr 链接 做细节参考
docs/develop/upgrade.md
Outdated
@@ -0,0 +1,27 @@ | |||
# Spiderpool upgrade |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
新增文件,没看到 更新 docs/mkdocs.yml
2.add upgrade markdown Signed-off-by: Icarus9913 <icaruswu66@qq.com>
b73c976
to
0fdcbba
Compare
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
Please consult the segments from your current release until now before upgrading your spiderpool. | ||
|
||
|
||
## Upgrade to 0.3.6 from (<=0.3.5) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
0.3.5- to 0.4.0 也是 这个 case, 但不符合这个 title
这样是否合适
upgrade from version <= 0.3.5 to any high version
(The ipam and spiderpool-controller will use this label to find the application corresponding auto-created IPPool, once we change it. It's incompatible with the previous version spiderpool)
The correlative PR: #1135 implements auto-created IPPool garbage collect, it will use the IPPool label
ipam.spidernet.io/owner-application
to trace back the corresponding application.But the current function implementation just use '-' to assemble the application identification.
For this, it's very hard to unpack every variable.
For instance, you could set the namespace as
ns398-174835790
and the deployment namedeploy398-82311862
. And it will return a string likeDeployment-ns398-174835790-deploy398-82311862
I suggest to use "_" rather than "-" as slash for spider subnet feature 'ipam.spidernet.io/owner-application' label value.
And the upper case will be
Deployment_ns398-174835790_deploy398-82311862
Signed-off-by: Icarus9913 icaruswu66@qq.com
What this PR does / why we need it:
fix bug
Which issue(s) this PR fixes:
#1161 (comment)