spidermultusconfig: validate customcniconfig if is valid #2153
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cyclinder
force-pushed
the
spidermultusconfig/custom
branch
from
4c2866f
to
fa659f7
Compare
Codecov Report
@@ Coverage Diff @@
## main #2153 +/- ##
==========================================
- Coverage 81.68% 81.17% -0.52%
==========================================
Files 49 49
Lines 5210 5210
==========================================
- Hits 4256 4229 -27
- Misses 792 823 +31
+ Partials 162 158 -4
Flags with carried forward coverage won't be shown. Click here to find out more. |
|
update the test/doc |
cyclinder
force-pushed
the
spidermultusconfig/custom
branch
from
fa659f7
to
dd57dfd
Compare
cyclinder
force-pushed
the
spidermultusconfig/custom
branch
from
dd57dfd
to
c767310
Compare
weizhoublue
added
the
cherrypick-release-v0.6
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
name: Pull request
about: Tell us about your contribution
labels: ["pr/release/none-required"]
Thanks for contributing !
Before submitting a pull request, make sure you read about our Contribution notice here: https://spidernet-io.github.io/spiderpool/contributing/development/pullrequest/#need-review
What this PR does / why we need it:
spidermultusconfig: validate customcniconfig if is valid
Which issue(s) this PR fixes:
#2151
Special notes for your reviewer:
make sure your commit is signed off