Spidercoordinator: It able to get CIDR from kubeadm-config #3129
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cyclinder
requested review from
weizhoublue,
ty-dc,
bzsuni,
Icarus9913 and
windsonsea
as code owners
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## release-v0.9 #3129 +/- ##
================================================
+ Coverage 81.10% 81.15% +0.05%
================================================
Files 49 49
Lines 5334 5334
================================================
+ Hits 4326 4329 +3
+ Misses 852 850 -2
+ Partials 156 155 -1
Flags with carried forward coverage won't be shown. Click here to find out more. |
ty-dc
approved these changes
Jan 24, 2024
cyclinder
force-pushed
the
cherry_pick_0.9
branch
from
63ec540
to
b13ff55
Compare
|
it is supposed to be a bug fix |
If the kube-controller-manager Pod is running as systemd precess rather than Pod, In this case, We can't get the CIDR from the KCM Pod. We can get the CIDR from the kubeadm-config configMap. Signed-off-by: cyclinder <qifeng.guo@daocloud.io>
cyclinder
force-pushed
the
cherry_pick_0.9
branch
from
b13ff55
to
884a6a4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the kube-controller-manager Pod is running as systemd precess rather than Pod, In this case, We can't get the CIDR from the KCM Pod. We can get the CIDR from the kubeadm-config configMap.
Thanks for contributing!
What type of PR is this?
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #3126
Special notes for your reviewer: