Spidercoordinator: It able to get CIDR from kubeadm-config #3130
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cyclinder
requested review from
weizhoublue,
ty-dc,
bzsuni,
Icarus9913 and
windsonsea
as code owners
cyclinder
force-pushed
the
cherry_pick_0.8
branch
2 times, most recently
from
798ded4
to
d904872
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## release-v0.8 #3130 +/- ##
=============================================
Coverage 81.01% 81.01%
=============================================
Files 49 49
Lines 5340 5340
=============================================
Hits 4326 4326
Misses 856 856
Partials 158 158
Flags with carried forward coverage won't be shown. Click here to find out more. |
ty-dc
reviewed
Jan 24, 2024
cyclinder
force-pushed
the
cherry_pick_0.8
branch
from
d904872
to
91a823f
Compare
|
CI 失败的原因： release-0.8 的 e2e 安装的 IPv6 单栈集群的 calico 有 bug，它仍有 IPV4、IPv6 的池。故在 IPv6 的集群中 auto 模式下仍获取到了 ipv4 的 pod CIDR。 将 release-0.8 的 test/scripts/install-default-cni.sh 中 151 行修改一下？保证 ipv6 模式下只有calico 的 ipv6 池？ ipv6)
kubectl delete ippools default-ipv4-ippool --force
kubectl patch ippools default-ipv6-ippool --patch '{"spec": {"cidr": "'"${CALICO_IPV6POOL_CIDR}"'"}}' --type=merge
;; |
|
[FAIL] SpiderCoordinator Switch podCIDRType to https://github.com/spidernet-io/spiderpool/actions/runs/7638721733/job/20818914107?pr=3130 |
cyclinder
force-pushed
the
cherry_pick_0.8
branch
from
91a823f
to
f3ad24b
Compare
ty-dc
approved these changes
Jan 25, 2024
weizhoublue
approved these changes
Jan 25, 2024
|
why can't merge this when we have two approves? |
|
If the kube-controller-manager Pod is running as systemd precess rather than Pod, In this case, We can't get the CIDR from the KCM Pod. We can get the CIDR from the kubeadm-config configMap. Signed-off-by: cyclinder <qifeng.guo@daocloud.io>
cyclinder
force-pushed
the
cherry_pick_0.8
branch
from
f3ad24b
to
0234532
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the kube-controller-manager Pod is running as systemd precess rather than Pod, In this case, We can't get the CIDR from the KCM Pod. We can get the CIDR from the kubeadm-config configMap.
Thanks for contributing!
What type of PR is this?
What this PR does / why we need it:
Cherry-pick
Which issue(s) this PR fixes:
Fixes #3126
Special notes for your reviewer: