-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
subnet feature: support to turn on or off the feature of managing automatic-ippool #3241
Merged
weizhoublue
merged 1 commit into
spidernet-io:main
from
Icarus9913:feat/wk/autopool-switch
Apr 8, 2024
Merged
subnet feature: support to turn on or off the feature of managing automatic-ippool #3241
weizhoublue
merged 1 commit into
spidernet-io:main
from
Icarus9913:feat/wk/autopool-switch
Apr 8, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Icarus9913
requested review from
weizhoublue,
ty-dc and
bzsuni
as code owners
February 22, 2024 09:23
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3241 +/- ##
==========================================
- Coverage 81.85% 80.57% -1.28%
==========================================
Files 50 50
Lines 5373 5380 +7
==========================================
- Hits 4398 4335 -63
- Misses 813 892 +79
+ Partials 162 153 -9
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Icarus9913
force-pushed
the
feat/wk/autopool-switch
branch
4 times, most recently
from
February 23, 2024 02:04
e3c041e
to
ddfc4af
Compare
weizhoublue
reviewed
Feb 23, 2024
weizhoublue
reviewed
Feb 23, 2024
weizhoublue
reviewed
Feb 23, 2024
weizhoublue
reviewed
Feb 23, 2024
weizhoublue
reviewed
Feb 23, 2024
Icarus9913
force-pushed
the
feat/wk/autopool-switch
branch
from
February 23, 2024 10:31
ddfc4af
to
77be1c4
Compare
…net feature Signed-off-by: Icarus9913 <icaruswu66@qq.com>
Icarus9913
force-pushed
the
feat/wk/autopool-switch
branch
from
February 26, 2024 01:32
77be1c4
to
5b55d69
Compare
weizhoublue
changed the title
add a switch to control creating auto-pool feature
subnet feature: support to turn on or off the feature of managing automatic-ippool
Apr 3, 2024
weizhoublue
reviewed
Apr 7, 2024
weizhoublue
approved these changes
Apr 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
EnabledSpiderSubnet
ipam.spidernet.io/subnet
andipam.spidernet.io/subnets
annotation. (This switch should based on enableEnabledSpiderSubnet
)Signed-off-by: Icarus9913 icaruswu66@qq.com
What this PR does / why we need it:
new feature
Which issue(s) this PR fixes:
close #3238