Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

subnet feature: support to turn on or off the feature of managing automatic-ippool #3241

Merged
merged 1 commit into from
Apr 8, 2024

Conversation

Icarus9913
Copy link
Collaborator

  1. allow the user to create SpiderSubnet resource based on a switch EnabledSpiderSubnet
  2. add a switch to control auto-pool application with ipam.spidernet.io/subnet and ipam.spidernet.io/subnets annotation. (This switch should based on enable EnabledSpiderSubnet)

Signed-off-by: Icarus9913 icaruswu66@qq.com

What this PR does / why we need it:
new feature

Which issue(s) this PR fixes:
close #3238

@Icarus9913 Icarus9913 added the release/feature-new release note for new feature label Feb 22, 2024
Copy link

codecov bot commented Feb 22, 2024

Codecov Report

Attention: Patch coverage is 90.00000% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 80.57%. Comparing base (d826534) to head (5b55d69).
Report is 2 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3241      +/-   ##
==========================================
- Coverage   81.85%   80.57%   -1.28%     
==========================================
  Files          50       50              
  Lines        5373     5380       +7     
==========================================
- Hits         4398     4335      -63     
- Misses        813      892      +79     
+ Partials      162      153       -9     
Flag Coverage Δ
unittests 80.57% <90.00%> (-1.28%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...pplicationcontroller/applicationinformers/utils.go 86.03% <100.00%> (+0.27%) ⬆️
pkg/ippoolmanager/ippool_informer.go 43.79% <0.00%> (-12.02%) ⬇️

... and 1 file with indirect coverage changes

@Icarus9913 Icarus9913 force-pushed the feat/wk/autopool-switch branch 4 times, most recently from e3c041e to ddfc4af Compare February 23, 2024 02:04
test/doc/subnet.md Outdated Show resolved Hide resolved
…net feature

Signed-off-by: Icarus9913 <icaruswu66@qq.com>
@Icarus9913 Icarus9913 added the pr/ready-review This pull is ready for review label Feb 27, 2024
@weizhoublue weizhoublue added this to the re milestone Feb 27, 2024
@weizhoublue weizhoublue changed the title add a switch to control creating auto-pool feature subnet feature: support to turn on or off the feature of managing automatic-ippool Apr 3, 2024
@weizhoublue weizhoublue merged commit 68d6660 into spidernet-io:main Apr 8, 2024
45 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr/ready-review This pull is ready for review release/feature-new release note for new feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

add a switch to control creating auto-pool feature based on SpiderSubnet feature
2 participants