Support getting serviceCIDR from spec.Containers[0].Args of kube-controller-manager Pod #3243
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3243 +/- ##
==========================================
- Coverage 81.85% 81.12% -0.73%
==========================================
Files 50 50
Lines 5373 5373
==========================================
- Hits 4398 4359 -39
- Misses 813 856 +43
+ Partials 162 158 -4
Flags with carried forward coverage won't be shown. Click here to find out more. |
ty-dc
force-pushed
the
serviceCIDR-from-args
branch
from
ce0e56a
to
50a75b7
Compare
ty-dc
changed the title
weizhoublue
reviewed
Feb 27, 2024
| @@ -336,6 +336,9 @@ func (cc *CoordinatorController) syncHandler(ctx context.Context, coordinatorNam | |||
| return | |||
| } | |||
|
|
|||
| // Spiderpool can automatically fetch ClusterCIDR. | |||
There was a problem hiding this comment.
fetchPodAndServerCIDR：how about pod CIDR
ty-dc
force-pushed
the
serviceCIDR-from-args
branch
from
50a75b7
to
38d30e8
Compare
Signed-off-by: ty-dc <tao.yang@daocloud.io>
ty-dc
force-pushed
the
serviceCIDR-from-args
branch
from
38d30e8
to
00f92bc
Compare
weizhoublue
approved these changes
Feb 27, 2024
Icarus9913
approved these changes
Feb 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for contributing!
What type of PR is this?
What this PR does / why we need it:
Which issue(s) this PR fixes:
In issue #3180, users encountered an issue where getting the serverCIDR failed in the rke2 cluster. The version they are using is v0.9.1, which has been fixed in PR #3211. But since new features are added to the main branch, the problem still needs to be fixed in main based on the new features.
The problem is as follows:
When kubeadm-config does not exist, get the podCIDR and serviceCIDR from the kube-controller-manager Pod. Due to different cluster deployment methods, there may be two types: Spec.Containers[0].Command and Spec.Containers[0].Args. For example, if the RKE2 cluster uses Spec.Containers[0].Args instead of Spec.Containers[0].Command, serviceCIDR will not be obtained, resulting in the inability to create Pods.
Fixes #3210