Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: support wildcard match for IPPool #3262

Merged
merged 1 commit into from
Apr 8, 2024

Conversation

Icarus9913
Copy link
Collaborator

@Icarus9913 Icarus9913 commented Feb 29, 2024

With the following ways of specifying IPPools(Pod Annotation, Namespace Annotation, CNI configuration file), you can also use wildcards *, ? and [] to match the desired IPPools.

For example:
ipam.spidernet.io/ippool: '{"ipv4": ["demo-v4-ippool1", "backup-ipv4*"]}'

Signed-off-by: Icarus9913 icaruswu66@qq.com

@Icarus9913 Icarus9913 added pr/not-ready not ready for merging release/feature-new release note for new feature labels Feb 29, 2024
@Icarus9913 Icarus9913 linked an issue Feb 29, 2024 that may be closed by this pull request
@Icarus9913 Icarus9913 added this to the v0.10 milestone Feb 29, 2024
Copy link

codecov bot commented Feb 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.27%. Comparing base (3ae7bf0) to head (bbed31c).
Report is 6 commits behind head on main.

❗ Current head bbed31c differs from pull request most recent head e023a12. Consider uploading reports for the commit e023a12 to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3262      +/-   ##
==========================================
+ Coverage   81.18%   81.27%   +0.09%     
==========================================
  Files          50       50              
  Lines        5372     5416      +44     
==========================================
+ Hits         4361     4402      +41     
- Misses        854      856       +2     
- Partials      157      158       +1     
Flag Coverage Δ
unittests 81.27% <100.00%> (+0.09%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
pkg/ippoolmanager/ippool_manager.go 87.32% <100.00%> (+1.44%) ⬆️
pkg/ippoolmanager/utils.go 94.28% <100.00%> (+0.95%) ⬆️
pkg/reservedipmanager/reservedip_manager.go 100.00% <100.00%> (ø)

... and 1 file with indirect coverage changes

@Icarus9913 Icarus9913 force-pushed the feat/wk/wildcard branch 3 times, most recently from 27d7256 to 0d172bc Compare March 1, 2024 06:37
@Icarus9913 Icarus9913 force-pushed the feat/wk/wildcard branch 2 times, most recently from 29a1883 to 362e07a Compare April 3, 2024 06:38
@Icarus9913 Icarus9913 added pr/ready-review This pull is ready for review and removed pr/not-ready not ready for merging labels Apr 3, 2024
@Icarus9913 Icarus9913 force-pushed the feat/wk/wildcard branch 4 times, most recently from 7731102 to bbed31c Compare April 7, 2024 03:38
Signed-off-by: Icarus9913 <icaruswu66@qq.com>
@weizhoublue weizhoublue changed the title add wildcard for IPPool selection feature: support wildcard match for IPPool Apr 8, 2024
@weizhoublue weizhoublue merged commit 3b4bf92 into spidernet-io:main Apr 8, 2024
41 of 42 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr/ready-review This pull is ready for review release/feature-new release note for new feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

default ippools supports to be selected by regular expression
2 participants