Fix panic in spidercoordinator informer #3269
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3269 +/- ##
==========================================
+ Coverage 81.12% 81.62% +0.50%
==========================================
Files 50 50
Lines 5372 5372
==========================================
+ Hits 4358 4385 +27
+ Misses 856 825 -31
- Partials 158 162 +4
Flags with carried forward coverage won't be shown. Click here to find out more. |
weizhoublue
previously approved these changes
Mar 1, 2024
Signed-off-by: cyclinder <qifeng.guo@daocloud.io>
cyclinder
force-pushed
the
spidercoorinator/fix_panici_coordinator_informer
branch
from
cde5d8e
to
e16d008
Compare
weizhoublue
added
cherrypick-release-v0.8
weizhoublue
approved these changes
Mar 1, 2024
ty-dc
approved these changes
Mar 1, 2024
github-actions bot
pushed a commit
that referenced
this pull request
Mar 1, 2024
…oordinator_informer Fix panic in spidercoordinator informer Signed-off-by: robot <tao.yang@daocloud.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for contributing!
What type of PR is this?
What this PR does / why we need it:
Fix panic in spidercoordinator informer: if the serviceCIDR resource can't be list, the serviceCIDRLister should be nil, in the case, we update the service cidr of the spidercoordinator.status from k8s service cidr.
Which issue(s) this PR fixes:
Fixes #3263
Special notes for your reviewer: