Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

spidermultusconfig: add missing filed for generateCoordinatorCNIConf #3283

Merged

Conversation

cyclinder
Copy link
Collaborator

Thanks for contributing!

What type of PR is this?

  • kind/bug

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #3282

Special notes for your reviewer:

@cyclinder cyclinder force-pushed the spidermultusconfig/tunePodRoutes branch 2 times, most recently from 6d65457 to 96add67 Compare March 4, 2024 11:16
Copy link

codecov bot commented Mar 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.12%. Comparing base (6aa148d) to head (fbb5c93).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #3283   +/-   ##
=======================================
  Coverage   81.12%   81.12%           
=======================================
  Files          50       50           
  Lines        5372     5372           
=======================================
  Hits         4358     4358           
  Misses        856      856           
  Partials      158      158           
Flag Coverage Δ
unittests 81.12% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@weizhoublue
Copy link
Collaborator

CI failed

@cyclinder cyclinder force-pushed the spidermultusconfig/tunePodRoutes branch 2 times, most recently from cf0a55f to 79b2a8f Compare March 5, 2024 03:41
Signed-off-by: cyclinder <qifeng.guo@daocloud.io>
@cyclinder cyclinder force-pushed the spidermultusconfig/tunePodRoutes branch from 79b2a8f to fbb5c93 Compare March 5, 2024 03:42
@Icarus9913 Icarus9913 merged commit 0712541 into spidernet-io:main Mar 5, 2024
44 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Set TunePodRoutes to false, but it does not take effect
4 participants