Spidercoordinator: sync kubeadm-config event to trigger the status update #3291
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3291 +/- ##
==========================================
+ Coverage 81.18% 81.62% +0.44%
==========================================
Files 50 50
Lines 5372 5372
==========================================
+ Hits 4361 4385 +24
+ Misses 854 825 -29
- Partials 157 162 +5
Flags with carried forward coverage won't be shown. Click here to find out more. |
ty-dc
added
the
cherrypick-release-v0.8
weizhoublue
previously approved these changes
Mar 5, 2024
|
I suggest to change to a new title that helps recognize what bug it is, in the release log |
cyclinder
changed the title
|
Does this PR only modify kubeadm-config? Changes to kube-controller-manager Pod cannot be synchronized? |
cyclinder
force-pushed
the
spidercoordinator/sync_kubeadm_config
branch
from
142e25f
to
344c444
Compare
ty-dc
previously approved these changes
Mar 6, 2024
Icarus9913
reviewed
Mar 6, 2024
Icarus9913
reviewed
Mar 6, 2024
cyclinder
force-pushed
the
spidercoordinator/sync_kubeadm_config
branch
from
344c444
to
f276fce
Compare
Signed-off-by: cyclinder <qifeng.guo@daocloud.io>
cyclinder
force-pushed
the
spidercoordinator/sync_kubeadm_config
branch
from
f276fce
to
76ab683
Compare
weizhoublue
approved these changes
Mar 6, 2024
ty-dc
approved these changes
Mar 6, 2024
github-actions bot
pushed a commit
that referenced
this pull request
Mar 6, 2024
…m_config Spidercoordinator: sync kubeadm-config event to trigger the status update Signed-off-by: robot <tao.yang@daocloud.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for contributing!
What type of PR is this?
What this PR does / why we need it:
we should watch the kubeadm-config configMap
Which issue(s) this PR fixes:
Fixes #3290
Fixes #3292
Special notes for your reviewer: