coordinator: rework GetDefaultRouteInterface to get pod's default route nic #3302
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…can be hijacked to the specified NIC. Signed-off-by: tao.yang <tao.yang@daocloud.io>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3302 +/- ##
==========================================
+ Coverage 81.12% 81.18% +0.05%
==========================================
Files 50 50
Lines 5372 5372
==========================================
+ Hits 4358 4361 +3
+ Misses 856 854 -2
+ Partials 158 157 -1
Flags with carried forward coverage won't be shown. Click here to find out more. |
ty-dc
added
kind/test
do-not-merge/waiting
and removed
kind/test
do-not-merge/waiting
labels
cyclinder
approved these changes
Mar 7, 2024
cyclinder
changed the title
weizhoublue
approved these changes
Mar 8, 2024
|
no cherry-pick ? |
ty-dc
added
cherrypick-release-v0.8
github-actions bot
pushed a commit
that referenced
this pull request
Mar 11, 2024
coordinator: rework GetDefaultRouteInterface to get pod's default route nic Signed-off-by: robot <tao.yang@daocloud.io>
github-actions bot
pushed a commit
that referenced
this pull request
Mar 11, 2024
coordinator: rework GetDefaultRouteInterface to get pod's default route nic Signed-off-by: robot <tao.yang@daocloud.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for contributing!
What type of PR is this?
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #3296
Special notes for your reviewer:
In IPv6 mode, a non-existent network card is set through PodDefaultRouteNIC, but the Pod has an IPv6 default route, but a null value is returned, thus skipping the synchronization of the default route and making the Pod successfully created. However, the creation should fail at this time and prompt "net2 don't exist in pod"