coordinator: ensure hijickRoute's gw is from hostIPRouteForPod #3358
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cyclinder
added
release/bug
cherrypick-release-v0.7
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3358 +/- ##
==========================================
+ Coverage 81.18% 81.60% +0.42%
==========================================
Files 50 50
Lines 5372 4299 -1073
==========================================
- Hits 4361 3508 -853
+ Misses 854 633 -221
- Partials 157 158 +1
Flags with carried forward coverage won't be shown. Click here to find out more. |
|
please attach an issue link for this |
updated. |
Signed-off-by: cyclinder <qifeng.guo@daocloud.io>
cyclinder
force-pushed
the
coordinator/fix_source_ip
branch
from
28583ba
to
f7e0192
Compare
weizhoublue
approved these changes
Apr 16, 2024
github-actions bot
pushed a commit
that referenced
this pull request
Apr 16, 2024
coordinator: ensure hijickRoute's gw is from hostIPRouteForPod Signed-off-by: robot <tao.yang@daocloud.io>
github-actions bot
pushed a commit
that referenced
this pull request
Apr 16, 2024
coordinator: ensure hijickRoute's gw is from hostIPRouteForPod Signed-off-by: robot <tao.yang@daocloud.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for contributing!
What type of PR is this?
What this PR does / why we need it:
Avoiding the GW properly comes from the nodelocaldns's IP when coordinator creates the hijack routes in the pod.
There are some os where
ip r getmay return src as the address of the node's nodelocaldns, which should be avoided.Which issue(s) this PR fixes:
Fixes #3359
Special notes for your reviewer: